Skip to content

Remove mentions of CloudSQL in README #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove mentions of CloudSQL in README #1057

wants to merge 1 commit into from

Conversation

arp242
Copy link

@arp242 arp242 commented Feb 1, 2020

Since it got removed in #1007.

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@shogo82148
Copy link
Contributor

I'm not a CloudSQL user, but In my understanding, you can still use CloudSQL with using the database/sql package.

In Google AppEngine Go 1.9 runtime, we have to use the google.golang.org/appengine package to connect CloudSQL.
In Go 1.11+ runtime, we can use the database/sql package and there is no need to use google.golang.org/appengine package.
#1007 only removes Go 1.9 runtime support. You can still use CloudSQL in Go 1.11+ runtime.

please see migration guide https://cloud.google.com/appengine/docs/standard/go111/go-differences?hl=en

@arp242
Copy link
Author

arp242 commented Feb 2, 2020

But it's no longer supported through this package, right? Or am I badly misunderstanding things here? 😅

@shogo82148
Copy link
Contributor

Not right.
This package doesn't support Go 1.9 runtime, and also Google doesn't support it.
In legacy Go 1.9 runtime, Cloud SQL needed the specific package.

But now, Cloud SQL supports MySQL protocol (ref. Cloud SQL for MySQL).
So you can use any driver that supports MySQL protocol (including the go-sql-driver/mysql package).

@arp242
Copy link
Author

arp242 commented Feb 2, 2020

Oh, okay; sorry for the noise 😅

@arp242 arp242 closed this Feb 2, 2020
@arp242 arp242 deleted the patch-1 branch February 7, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants